fix: preserve image tool results for Claude - #8
Closed
lantzleiweke wants to merge 1 commit into
Closed
lantzleiweke wants to merge 1 commit into
lantzleiweke wants to merge 1 commit into
Conversation
JosueGalRe
added a commit
to JosueGalRe/opencode-claude
that referenced
this pull request
Sep 22, 2026
…d media Tool results were reduced to text before resuming the parked SDK call, so read-tool images never reached the model. Convert attachments to MCP image content blocks, and merge the synthetic 'Attached media from tool result:' user message OpenCode emits for openai-compatible providers. Upstream: openchamber#8 + media part of openchamber#11
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
collectToolResults()reduced every tool response toextractTextContent(), and the SDK MCP handler rebuilt a text-only result. OpenCode had stored the PNG attachment correctly, but the provider bridge discarded it before Claude received the tool result.Verification
bun test/smoke.tsbun run build{ type: "image", data, mimeType }content